Google Git
Sign in
chromium / chromium / src / a58bd6d042ccb5be5d196bd546ba1b1039fdb080
commita58bd6d042ccb5be5d196bd546ba1b1039fdb080[log] [tgz]
authorEtienne Bergeron <etienneb@chromium.org>Mon May 26 21:14:37 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 26 21:14:37 2025
tree154c2513fd6453946c06e2159fa7d2ed4df82e02
parent046f6798f268669593f7d12c1ff41457a979b7e5 [diff]
Fix a crash due do retrieving diagnostic after database open failed.

This CL is fixing an crash caused by a databased not being opened while
requesting diagnostic information.

The error goes like this:
  * OpenDatabase
    - sqlite_open failed
    - db_ is not set, and stays null
    - error_calback is called
  * HistoryBackend request the diagnostic error
    - sql::Database::GetDiagnosticInfo
    - sql::Database::Execute

And the function sql::Database::Execute has a DCHECK that enforce the
db_ to not be null or to be poisoned. see:
https://source.chromium.org/chromium/chromium/src/+/main:sql/database.cc;l=1522;drc=a6f95e740f15dc909935fee1c41c77aeefdaa727

Test: Running the test without the fix does crash.
Bug: 420369590
Change-Id: I60b5af1d0a504c7bffd61aadb977d9aac1158a78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6586533
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1465663}
2 files changed
tree: 154c2513fd6453946c06e2159fa7d2ed4df82e02
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.