Add text justifying why we call MediaControls::Reset() After investigating we do need to call MediaControls::Reset(). Many of the state computations inside of MediaControlsImpl key off of the controls visibility, so a full state reset is needed in order to put the controls in the right state. It's possible we could create a more scoped version of Reset() just for the controls that shift with the visible state, but there don't seem to be any issues with the bigger hammer that is Reset(). Bug: 448699375 Change-Id: Ic17991a13151e023a269497b90ab8fb9e5aeef31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7007030 Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1524830}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.