| commit | a5b94b8fa0341f8b1250f98ca8b017fd0e97d05d | [log] [tgz] |
|---|---|---|
| author | dpapad <dpapad@chromium.org> | Wed May 01 14:03:17 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 01 14:03:17 2024 |
| tree | 66b5482550f987f4652f74a188d790d52ec86e28 | |
| parent | 5db8a14cabce36adaa77534082222d72728c3b97 [diff] |
WebUI: Enforce querySelector<Type>() pattern via ESLint, part 7 (last) In this part, amending the existing checks to also catch such cases. All violations have been fixed in precursor CLs. A common misuse of querySelector/querySelectorAll is to use a type cast, like this.shadowRoot.querySelector(...) as Type instead of leveraging the type parameter, like this.shadowRoot.querySelector<Type>(...) The previously added ESLint checks miss cases where a "not null" typecast exists, like this.shadowRoot.querySelector(...)! as Type Fixed: 1521107 Change-Id: I0bebe973d3467b92c53525ac4bc0337814481bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502593 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#1294846}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.