Google Git
Sign in
chromium / chromium / src / a5eb414a4f0bd3412b1b588cc7e1bbc677b497ed
commita5eb414a4f0bd3412b1b588cc7e1bbc677b497ed[log] [tgz]
authorYao Xiao <yaoxia@chromium.org>Fri Jan 05 18:28:38 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 05 18:28:38 2024
treea52b97504836b1337fc928dacd48dc06873a89f5
parent22b0d711657b451b61d50dd2e242b3c6e38e6ef5 [diff]
[shared storage] Fix duplicate console outputs handling

Issue: "console" outputs became automatically supported with the
worklet integration with DevTools. It conflicts with the pre-existing
manual logging via `devtools_instrumentation::LogWorkletMessage()`,
causing duplicate logging of each message.

This CL:
1) Removes the manual devtools_instrumentation::LogWorkletMessage().
2) Re-purpose mojom::SharedStorageWorkletServiceClient::ConsoleLog() to
::DidAddMessageToConsole(). We still want the observer method, so that
existing tests that relies on `WebContentsConsoleObserver` can still
work. The idea is to keep mimicking what's being done for console
outputs from Window context, which manually triggers the observer
method via mojom::LocalFrameHost::DidAddMessageToConsole().
3) Use the original log level in the observer method, rather than
always using `kInfo`. This aligns with the actual log level.

Bug: 1515719
Change-Id: I7a15d4727d2affba03c2e575c251d63b09c62404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5171585
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243503}
6 files changed
tree: a52b97504836b1337fc928dacd48dc06873a89f5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.