Google Git
Sign in
chromium / chromium / src / a607790d255fafd36854d978bf8e95428b0fcbab
commita607790d255fafd36854d978bf8e95428b0fcbab[log] [tgz]
authorHidehiko Abe <hidehiko@chromium.org>Fri May 26 10:19:06 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 26 10:19:06 2023
tree474d58bc4f6415ce36cc8b956ac3ab28785ab4a4
parent3555d5526cba31fa3cdfeff50819c521cdde3c7d [diff]
Fix MergeLacrosPreferences.

The original code used dotted paths to track the current position
on traversing over Lacros preferences.
It assumes that there're no keys containing '.', but it is wrong,
e.g. some preferences have URL (like "http://www.google.com") as keys.

As a result, those are wrongly split on merging, and causing crash
issues, such as crbug.com/1448042 and crbug.com/1448648, and prevent
users to login sessions.

This CL get rid of using the hack to use dotted path for the merging
to fix the problem.

BUG=1449100, 1448042, 1448648
TEST=Ran unittest locally.

Change-Id: Icd9deae0bd9435ca1cd75f0731e54be5e514cc25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568046
Reviewed-by: Yuta Hijikata <ythjkt@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149638}
3 files changed
tree: 474d58bc4f6415ce36cc8b956ac3ab28785ab4a4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.