Google Git
Sign in
chromium / chromium / src / a61e8a18b549c1b8d53bfe7f9e566cde5b6f9658
commita61e8a18b549c1b8d53bfe7f9e566cde5b6f9658[log] [tgz]
authorKevin Ellis <kevers@google.com>Thu Feb 03 17:45:36 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 03 17:45:36 2022
treed664807fa0378f100620e8e72893afdb9437b8af
parent297ab5f06e68dacfc12785daa7e566d69a1d2fe6 [diff]
Fix flake in upload-and-send-events-replacement.

There are two code paths for updating animations. The first is called
in response to an animation frame, and the second is an on-demand style
calculation called during style and layout.  Both calls were queuing
an animation finished microtask, yet only the animation frame path
updated the replace state of animations. A running animation should
only finish in response to an animation tick if no explict API calls are
made such as animation.finish. We should not be updating the finished
state for an on-demand style update.

Bug: 1281818
Change-Id: I30223a3c6ae856789c45c2b521edf9fa2ca308ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429421
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966797}
1 file changed
tree: d664807fa0378f100620e8e72893afdb9437b8af
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.