| commit | a68f0b6dba9f0b005d45ef4bb676d2736e2f1ce1 | [log] [tgz] |
|---|---|---|
| author | Joe Mason <joenotcharles@google.com> | Thu Sep 25 06:20:39 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 25 06:20:39 2025 |
| tree | 2e026113459810d6d0aea0288b10d343aa43eab3 | |
| parent | df5ec45e90642e2b9269896af95be02aa5f5ec83 [diff] |
Fall back to Receiver if DirectReceiver::Bind fails Binding a DirectReceiver to another thread involves transferring the PendingReceiver's endpoint to a ThreadLocalNode. This can theoretically fail if the connection to that node closes, or more practically if the async connection setup failed an error might be surfaced at the first transfer attempt. Binding the PendingReceiver to a Receiver in the global node doesn't involve any extra connections so should succeed even if the ThreadLocalNode transfer fails. The Receiver has the same functionality as the DirectReceiver, just less efficient because it involves an extra thread hop, so this patch treats DirectReceiver failures as non-fatal and just uses a regular Receiver instead. This also logs all failures to UMA so we can tell how often DirectReceiver is falling back to Receiver. NO_IFTTT=New IFTTT annotation. Bug: 445243335 Change-Id: I0a4fc09f6d44b851301b500d7ded2f989892f24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6974826 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Luc Nguyen <lucnguyen@google.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Nafis Abedin <nafisabedin@google.com> Cr-Commit-Position: refs/heads/main@{#1520378}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.