Google Git
Sign in
chromium / chromium / src / a750f711c0b66610df529d734299da92a3396a55
commita750f711c0b66610df529d734299da92a3396a55[log] [tgz]
authorJoe Mason <joenotcharles@google.com>Thu Jul 15 14:47:20 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 15 14:47:20 2021
tree0c22c61c8861aef67ae30886e166a9421acf47e7
parent5cde68e40813f9d6ea7ca8f0d017a3fec02e7e48 [diff]
Re-enable V8DetailedMemoryRequestAnySeqTest.SingleProcessRequest

This test was sometimes timing out on Windows even though there is a timer that
should prevent the only RunLoop from running forever. I can't reproduce the
issue locally.

This simplifies the timeout tracking using base::test::ScopedRunLoopTimeout,
and adds more local timeouts around every step that looks like it could loop
forever, including the test harness setup and teardown. The way if it continues
to flake it should hit a ScopedRunLoopTimeout and we can tell which, or
continue a top-level test timeout in which case we know there's a deadlock
outside a runloop somehow.

R=chrisha

Bug: 1212792
Change-Id: I9507994f819fd1630a43b14b4a27cca9fc3da696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3027651
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Auto-Submit: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#901949}
1 file changed
tree: 0c22c61c8861aef67ae30886e166a9421acf47e7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.