| commit | a7e46687c130cc54bca6f91a2e11db4523c6eacd | [log] [tgz] |
|---|---|---|
| author | Raymond Toy <rtoy@chromium.org> | Wed Aug 19 22:51:55 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Aug 19 22:51:55 2020 |
| tree | ee258d90afd0f601e9fc90ca941d2eb55c582b55 | |
| parent | 6f96a749c2be3d15fd0ce69b59b627c86064f6cb [diff] |
Add CHECK to help determine source of crash Add a CHECK before we break out of the loop in ComputeIndices. This has never happened in my testing, so this is just a guess. If we do get crashes, perhaps we can get better information about what's happening. This is important because if we do exit the loop early, we're not telling ComputeOutput about it and the read indices may not be set up correctly for that. Also, update frames_processed to tell ComputeOutput how many values were computed so ComputeOutput doesn't compute more outputs than needed. I think letting this bake for a week or so will be enough to gather enough information if this is the case. Bug: 1116104 Change-Id: Id0ab1d3ca801196fc49b878349f469cbd4f6e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358815 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799827}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.