Google Git
Sign in
chromium / chromium / src / a7ef559fa3abb12c05c8c9687d0f2f0712533b51
commita7ef559fa3abb12c05c8c9687d0f2f0712533b51[log] [tgz]
authorGauthier Ambard <gambard@chromium.org>Fri Aug 06 11:39:45 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 06 11:39:45 2021
tree2b8ba1ff22e92207e412e7b4bbd7482ab0b14a84
parent76e45c7286d5d428ed713f01d0f476a1a24d5e78 [diff]
[iOS] Fix Avatar resizing

The resizing was taking into account the scale of the image but with
a projected size in pt (which is considering the scale of the screen).
This CL changes the resize utils to always take the size of the screen
into account.

It also unifies all the places where the avatars were used to make sure
they use the ResizedAvatarCache, allowing for a more consistent
user experience.

The changes to the resize util impacts the Thumbnail generator used
when sending a thumbnail of the page to the share util. This side
effect shouldn't impact the user experience.

Before: https://drive.google.com/file/d/1Znkx59IHHPYOkZmT2DBRmm4IvKgSSBY5/view?usp=sharing&resourcekey=0-rq5VP-PZAj7otdtR_5Ctqg
After: https://drive.google.com/file/d/1jq7lDQUNxOYFpb7LCvAUcETp2j1tiiI4/view?usp=sharing&resourcekey=0-rHO-DA4te-lJawzqSAHXAQ

Bug: 1171272, 1236091
Change-Id: Ie9e304cfaa94a9f0e4b761485c34d242b0652c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3071299
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909241}
21 files changed
tree: 2b8ba1ff22e92207e412e7b4bbd7482ab0b14a84
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.