commit | a80fab0c9c007639e957e3caa637ba09c437b3fa | [log] [tgz] |
---|---|---|
author | Eshwar Stalin <estalin@chromium.org> | Wed Jun 01 01:29:32 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 01 01:29:32 2022 |
tree | 26e3b634ba29eabf7505a51a069e3241279ec4a8 | |
parent | 32853fa8c4b9c84ab0f546ff93b3f50555cdcbe8 [diff] |
Fix for an issue where user isn't able to mute tab The main issue is we always attempt to delete the current site URL from the exception list if the target setting matches the default value. This has two issue, (1) First, the site URL might not exist in the exception list since the override is from a less specific URL e.g. wildcard. (2) Second issue is we have to add the specific URL to achieve the desired behavior if there is a less specific rule present in the exception list. Additional the CL also contains a small fix for the issue where adding an exception rule like wildcard isn't causing settings to refresh correctly to show the added entry. This issue is fixed in site_list.ts to handle the appropriate notification triggered from the handler. Bug: 1226058 Change-Id: I0d36f19171556855ca9680f3c507f5d22cf42e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3669780 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Eshwar Stalin <estalin@chromium.org> Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009393}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.