commit | a816d75e32fd27a8af920227882f2069eb2f7d6d | [log] [tgz] |
---|---|---|
author | Scott Violet <sky@chromium.org> | Tue Nov 15 23:50:58 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 15 23:50:58 2022 |
tree | ad1a832355d89b2dd5adb2bbab8fd68771cce05b | |
parent | 8ef621a83bb8afbbb6f05d6e67c4c2be92d057bf [diff] |
Revert "SavedDesk: Implement Saved Desk Builder boilerplate" This reverts commit 1a4ba3e14e9f7c2d9ce85f8f1065a2450b2ae005. Reason for revert: Causes failure on msan bot because of use of uninitialized value. See https://bugs.chromium.org/p/chromium/issues/detail?id=1385169 . Original change's description: > SavedDesk: Implement Saved Desk Builder boilerplate > > This CL implements the saved desk builter boilerplate code needed > to build comprehensive tests for the Saved Desk storage format. > These builders are not completely covered in tests but will be > as we approach the overall goal of testing the Saved Desk format. > > The builders currently work with the tests that use them. More > test coverage is coming up, for more information see the attached > implementation plan. > > This version of the change repairs a memory leak. The leak was > confirmed fixed by running affected tests with asan/lsan > > Implementation plan: go/saved-desk-format-consistency-ip > > Design: go/saved-desk-format-consistency-dd > Bug: b/248645924 > Change-Id: Icb2f7e181b97c5d25ae2c78745b551fe27a364a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024034 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Yanzhu Du <yzd@google.com> > Commit-Queue: Avynn Donaghe <avynn@google.com> > Cr-Commit-Position: refs/heads/main@{#1071768} Bug: b/248645924, 1385169 Change-Id: I0dc1159364f72c25ae809a0bcaf9f91fb286fdb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4029379 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Darren Shen <shend@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071917}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.