commit a84b0a570a858b971b187f57fc13ea20cd810604
author Florian Leimgruber <fleimgruber@google.com> Thu Aug 29 16:22:51 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Aug 29 16:22:51 2024
tree 55b30cbe2dc78ad6a990e0ae6ed2b79b3ea8f4c7
parent aa5c5660bf56ebb69d92e47b3135550e42e0ffd1

PersonalDataManagerTestBase -> PaymentsDataManagerTestBase

The class is currently used as the base class in three unittest files:
ADM unittest, PayDM unittest and PaymentsDataCleaner unittest.

Since payments has two separate databases (on disk + in memory), a lot
of the setup in PersonalDataManagerTestBase is unnecessary for ADM
purposes. Similarly, some of the logic (such as strike databases) is
exclusive to addresses. For this reason, this CL:
- Makes PersonalDataManagerTestBase::MakePrimaryAccountAvailable()
  a free function in personal_data_manager_test_utils.h. This is useful
  for all tests. Code moved without changes, except for introducing
  two parameters for fields that used to be members.
- Moves PersonalDataManagerTestBase::InitPersonalDataManager() to the
  PaymentsDataCleaner unittest, because it's only called there*.
- Moves address-relevant members of PersonalDataManagerTestBase to the
  ADM unittest and removes them from PersonalDataManagerTestBase.
- Renames PersonalDataManagerTestBase to PaymentsDataManagerTestBase and
  renames the file.

* Ideally, this test shouldn't depend on the PersonalDataManagerTestBase
  at all and instead just use the TestPayDM (like the AddressDataCleaner
  is using the TestADM). This hopefully happens in a follow-up, but I'm
  still experimenting with what the nices way to refactor that is. See
  crrev.com/c/5823218, for example.

Bug: 40100455
Change-Id: I7dbb99601a0b4453b364e699d3720de904f74223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5823617
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Cr-Commit-Position: refs/heads/main@{#1348684}