commit | a84e489930d589c07a68df144f3f7cfa75b87c2c | [log] [tgz] |
---|---|---|
author | manukh <manukh@chromium.org> | Thu Nov 02 23:53:06 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 02 23:53:06 2023 |
tree | d91b80be72a9083fabf9c5a9d2cf1c116b90f860 | |
parent | f7410486c531dcb46c8ef30c1ddb05883264bc9d [diff] |
[omnibox][ml] Adds flag to pretend all suggestions are defaultable When enabled, all matches set `allowed_to_be_default_match` to true. Traditionally, few matches are allowed to be default: - Trivial URL/search what you typed matches - Searches prefixed by the input - URLs prefixed by the input - Shortcut texts prefixed by the input This limitation is due to the cost (both in terms of implementation and simplicity and readability for the user) of upgrading the UI to support inlining more texts. So we have a chicken-and-egg problem, we don't want to invest in the UI until we know lifting this limitation will improve ranking greatly; we won't know if ranking will benefit greatly unless we run experiments; we can't run experiments unless we fix the UI. This CL adds a flag to lift the limitation without fixing the UI or covering all edge cases. It's not launchable or experimentable. But maybe by dogfooding it we can estimate both a) how beneficial is this to ranking, and b) what we need to address to make this launchable. Bug: 1405555 Change-Id: If6d8384885264b3ffe6d84952ac95850b7b13441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5001797 Commit-Queue: manuk hovanesian <manukh@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/main@{#1219210}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.