commit | adc7a5a61d241ed589b65e2581c081008fbbfcc8 | [log] [tgz] |
---|---|---|
author | Amr Aboelkher <amraboelkher@chromium.org> | Thu Jun 17 10:54:13 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 17 10:54:13 2021 |
tree | dc69daac3dbc964cc5fc628e2287dfe1f5e36a43 | |
parent | d3319f7772e7350cb006c459b7d8ab3525dba0f8 [diff] |
Revert "Fix ClientSideDetectionHost disconnecting Mojo pipe on new render frame" This reverts commit e68601a2228fb1f59572d114f41c9a35c8103d8b. Reason for revert: Failure of MAC ASan 64 build (see https://ci.chromium.org/ui/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20(1)/69921/overview). The test failure: ClientSideDetectionServiceBrowserTest.NewHostGetsModel. This is the only CL that changes this area. See crbug.com/1221113. Original change's description: > Fix ClientSideDetectionHost disconnecting Mojo pipe on new render frame > > When a new render frame is created, we currently send it the CSD model > in case it's in a new process. As implemented, this was disconnecting > the old pipe and reusing. This is problematic if there are pending > classifications that should return on the old pipe. The solution is to > maintain a collection of mojo::Remotes in the ClientSideDetectionHost, > one per active RenderFrameHost > > Bug: 1217128 > Change-Id: Ia25372be894a0dca141f6421b91da16c15962199 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2944723 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#893197} Bug: 1217128 Change-Id: Ie60983e111df4cabfd49311267b4866fbb223aa6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2968303 Auto-Submit: Amr Aboelkher <amraboelkher@chromium.org> Owners-Override: Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#893385}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.