commit | a864c701d0891bc3b4c5edccb85958d3f377dfb3 | [log] [tgz] |
---|---|---|
author | Evan Stade <evanstade@microsoft.com> | Fri May 16 18:31:11 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 16 18:31:11 2025 |
tree | 337ac5593b50cefde02979aebf3318160a3c0be6 | |
parent | 7ab4f004ea27acf236e12d674a7fde7398d58d3c [diff] |
IDB: make backend Status more independent from leveldb::Status The Status struct is fairly messy as it creates leveldb::Status instances in backend-agnostic code. Not only does this not make sense for the SQLite backend, it also makes it harder to track the source of an error when using the LevelDB backend, as it's difficult to distinguish between an error detected by Chromium and an error detected by LevelDB. This change attempts to improve the state of the world, but doesn't aim for perfect abstraction. It makes it easier to create error statuses in a SQLite world, and the dependency on LevelDB will eventually go away on its own when we remove support for the LevelDB backend. Bug: 40253999 Change-Id: Ic28b9a355151bdecd0a5464021c5c9e2a9322303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532677 Reviewed-by: Abhishek Shanthkumar <abhishek.shanthkumar@microsoft.com> Commit-Queue: Evan Stade <evanstade@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1461508}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.