[NTPShortcuts] Migrate from using UseMostVisitedTiles to ShortcutsType pref

Currently, New Tab page supports two shortcuts: MostVisitedSites and
CustomLinks. On desktop, user selection is stored in a boolean pref and
the logic for the shortcuts relies on the assumption that there are only
two shortcut types.

Since we plan to add a third managed shortcuts view, this migration
increases flexibility for customizing shortcuts by storing user
input in an integer preference. For the new preference, we use
the following mapping:
- 0 = TopSites
- 1 = CustomLinks
- 2 = EnterpriseShortcuts (to be added in a future CL)

To minimize impact on android and link mixing, MostVisitedSites will
store a boolean for each allowed shortcut type (custom link and enterprise
shortcuts in a later CL) which allows platforms to decide which
shortcut types to allow.

This change does the following:
- Renames the DeletedTileType to TileType for enum mapping
- Adds migration code to migrate NtpUseMostVisitedTiles to
NtpShortcutsType
- Updates the MostVisitedSites service and handler,
CustomizeChromePage handler, and New Tab Page handler

TODOs have been added to update TS and mojom files with the new enum.

Bug: b:438302330
Change-Id: I8f3c79f1135ae65ddedbcfd81fbe689d055abf12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6871359
Commit-Queue: Alex Chen <alexwchen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1507114}
27 files changed
tree: 4f8523cd56299cb4161614cb9a01094aa0636e2d
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.