commit | a8856ecbc27caac10eb22318ebd2c3d6bbb9dd9f | [log] [tgz] |
---|---|---|
author | Kush Sinha <sinhak@chromium.org> | Wed Sep 01 14:28:31 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 01 14:28:31 2021 |
tree | 35ffbb96d851cfda422bf630571948abcfedcce3 | |
parent | 43ea2022ed3f9820f9757165045b88ee47d7623f [diff] |
Revert "Renderer-initiated history navigations should actually be flagged as renderer initiated" This reverts commit 5d955f77c66a4bd5c677726ede44e219d99d5eeb. Reason for revert: Failing DisableExtensionBrowserTest.VisitReenabledExtensionInSubframe. https://crbug.com/1245636 Original change's description: > Renderer-initiated history navigations should actually be flagged as renderer initiated > > Currently, all history navigations are considered browser-initiated, > even if they are initiated via the javascript history API. However, > there are some use cases where it would be good to know where the > history navigation came from. > > There are several callsites that assume all history navigations are > browser-initiated, so update those. Also, a few DCHECKs are no longer > valid, because they assume that a renderer-initiated navigation will > always have an initiator origin. Now, if a renderer-initiated history > navigation goes back/forward to an entry that was originally > browser-initiated, a renderer-initiated navigation can have no > initiator origin. > > Bug: 1127317 > Change-Id: Iffe728bd911fe9a851f8fe0fc480b60d1ade29dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3078919 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Arthur Hemery <ahemery@chromium.org> > Cr-Commit-Position: refs/heads/main@{#917005} Bug: 1127317, 1245636 Change-Id: I77fb77632c6244c4f777740da26ecddd4aa46984 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3135320 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Kush Sinha <sinhak@chromium.org> Reviewed-by: Martin Rodriguez <rodmartin@google.com> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/main@{#917232}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.