Google GitGoogle Git
Sign in
chromium/chromium/src/a8b3df55ddea2cfa6d049dea59720d8bc40c01dc
commit
a8b3df55ddea2cfa6d049dea59720d8bc40c01dc
[log]
author
Longbo Wei <longbowei@google.com>
Wed Sep 13 17:16:09 2023
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Sep 13 17:16:09 2023
tree
d2eb868e1784dd977f801ecaaec552e52e98d572
parent
91b88904a6db2d3b68cb3112c133eaef58e40be3 [diff]
shortcuts: Improve a11y of app main page.

This CL improves a11y of the app main-page when customization is
enabled. The updates include:
* Add aria-label for the accelerator-row similar to search-result-
  row.
* Add aria-label for edit-button.
* Move common functions in acceleartor-row and search-result-row to
  shortcut_util file for cleaner code.
* Remove aria-label in `input-key` and replaced it with described-by.
  aria-labels are typically used for interactive elements.
  Additionally,since 'accelerator-view' already contains an aria-label
  now that can be used in tast-tests, this change helps avoid the issue
  of ChromeVox announcing the accelerator twice.
* Update unittest to reflect the changes.

video: http://go/scrcast/NDgwMzMzNDc5NDkwMzU1MnwzMTFlMDM1Ny0yMA

Test: Manual && browser_test
Bug: b:216049298
Change-Id: I479fc5c7db37fb72a803178b0a6e0cec6cc1852a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4851245
Commit-Queue: Longbo Wei <longbowei@google.com>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1196087}
18 files changed
tree: d2eb868e1784dd977f801ecaaec552e52e98d572
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. weblayer/
  52. clank
  53. internal
  54. ios_internal
  55. native_client
  56. signing_keys
  57. v8
  58. .clang-format
  59. .clang-tidy
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.