commit | a966e5e4410d11274eb7b51b59fce4f8d26af4d2 | [log] [tgz] |
---|---|---|
author | David Munro <davidmunro@google.com> | Mon Mar 14 23:16:08 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 14 23:16:08 2022 |
tree | e03b31bec1927b3ec760eb954ca182cdf43ddea6 | |
parent | d9bc939a9d8cc3abb3a6f98fdc1362709ff59526 [diff] |
borealis: ConciergeClient can be null in unit tests Even if DBusThreadManager is initialized, if a test hasn't explicitly initialized Concierge (e.g., maybe they just need Cicerone) ConciergeClient will be null. So check for ConciergeClient instead. Bug: None Test: Unit tests that previously crashed now don't Change-Id: I2ba66ad57c8d7adfbb37685ce0a1b0a0d9aee178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3515434 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by: Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/main@{#980839}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.