Google Git
Sign in
chromium / chromium / src / a9770a4da6ee5d85636b7a852543b4793059f6f0
commita9770a4da6ee5d85636b7a852543b4793059f6f0[log] [tgz]
authorHenrik Boström <hbos@chromium.org>Tue Apr 12 08:22:45 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 12 08:22:45 2022
tree92d43710f01066d93021859f6ba7d9db422ed115
parent729bb0f42d9c5151544f39cbc7fd01a612e63576 [diff]
RtpContributingSourceCache: Avoid theoretical use-after-free.

The `pc_` reference is a WeakPersistent, so it could become null causing
MaybeUpdateRtpSources() not to update the sources, resulting in
`rtp_sources` being null. This CL adds a guard to prevent
use-after-free.

Just a sanity check - I don't think this can happen in practise due to
RTCRtpReceiver having a strong reference to the PC which would prevent
the PC from going away while calling getContributingSources() is still
a possibility. But in case some assumption changes in the future...

Bug: chromium:1150311
Change-Id: If66cc8492f457c145f380adbbebaf1ab594974d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3578751
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#991405}
1 file changed
tree: 92d43710f01066d93021859f6ba7d9db422ed115
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.