Clean up Attribution Internals TypeScript This CL contains no functional changes, but does: - Use readonly annotations where applicable - Use visibility annotations where applicable - Use parameter properties in constructors where applicable - Make Column::compare optional instead of nullable - Require TableModel properties to be specified in its constructor - Make TableModel::getRows abstract - Remove unused compare parameter from ValueColumn constructor - Share common columns between EventLevelReportTableModel and AggregatableAttributionReportTableModel - Remove explicit casts from ReportTableModel subclasses by making ReportTableModel generic across the actual Report subclass Change-Id: I0b4f287fd65fc29cadbfaff6f3a9e9d30c77e3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4106909 Reviewed-by: Nan Lin <linnan@chromium.org> Quick-Run: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1083156}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.