| commit | aa147bcbc26ff968694e68bd7e83b858e471382f | [log] [tgz] |
|---|---|---|
| author | Peter Kotwicz <pkotwicz@chromium.org> | Wed Nov 20 16:49:11 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 20 16:49:11 2019 |
| tree | 0e5f4314d58b6a956a2207da6aa6f12d089b1f56 | |
| parent | 80578fd73c704ce90aad241aa381d8b7fd2d3dac [diff] |
Revert "Fill in the first pass of the parser to analyze hprof files." This reverts commit b30f46fd080f367409b503e193d3dd42b0570bd9. Reason for revert: Compile error in hprof_buffer_android_unittest.cc on x64 bot. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8896255126674550192/+/steps/compile/0/stdout Original change's description: > Fill in the first pass of the parser to analyze hprof files. > > The main purpose of the java heap profiler is to obtain a heap dump in > the form of an hprof file and then parse the hprof file. Currently, > there exists an empty parser that skips over everything in the hprof > file. > > With CL, we first parse each instance for given fields (object_id, > names, etc..) and then store these values in different instance > objects. We will be using these instance objects in the next CL which > is the second pass over. > > Bug: 1012072 > Change-Id: Ibe249056c180dd07b907ada129898248c91cbaec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898481 > Commit-Queue: ssid <ssid@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716986} TBR=nyquist@chromium.org,ssid@chromium.org,zhanggeorge@google.com Change-Id: Ic1a61810ab7d669b2f2fbae5786e30c17eff1970 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926535 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#717040}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .