commit aa3633880a16b4b05ab076e3ac1f1674f47e3e51
author Christopher Cameron <ccameron@chromium.org> Wed Sep 20 17:32:32 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 20 17:32:32 2023
tree 5039f848fd8a81d2756f3f0d346f7b8dc12b89e2
parent 7601b4b64d13594dde5c9d559d9f6dde563c5f6c

Revert "[view-transition] Stop BrowserCompositorMac from calling WasShown while"

This reverts commit 8c4a1b3b564495c2e884b6bcb1f053a9afb4fe25.

Reason for revert: Introduced crbug.com/1484982

Original change's description:
> [view-transition] Stop BrowserCompositorMac from calling WasShown while
> hidden
>
> Calling DelegatedFrameHost::WasShown() while hidden will assign
> `first_local_surface_id_after_navigation_` with the LocalSurfaceId
> of `BrowserCompositorMac`. This LocalSurfaceId is considered
> stale for BFCache restoration with ViewTransition because such
> restoration will have customized primary and fallback SurfaceIds.
>
> When the fallback content timer is up, the stale value of
> `first_local_surface_id_after_navigation_` will be used to reset the
> fallback SurfaceId, which confuses Viz, causing a white screen.
>
> What this CL means:
> - As long as we are hidden: HasNoCompositor.
> - `SetParentUiLayer` used to be always "successful" because even though
>   we are hidden, we use UseParentLayerCompositor to represent the state.
>   With this CL, `SetParentUiLayer` won't re-parent `root_layer_` if we
>   are hidden. `root_layer_` will be re-parented next time we become
>   visible (HasNoCompositor->UseParentLayerCompositor).
>
> Bug: 1475903, 1415340
> Change-Id: I001054783669754010034120dc118cf3d6d363f9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4827324
> Reviewed-by: Bo Liu <boliu@chromium.org>
> Commit-Queue: William Liu <liuwilliam@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1194845}

Bug: 1475903, 1415340
Change-Id: I450935f03f46433a12ae6c5a42496383eba1669d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4878773
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1199096}