commit | aa5b43bae66ac6d129cb15efd15ca360c27aaeac | [log] [tgz] |
---|---|---|
author | Siye Liu <siliu@microsoft.com> | Thu Aug 26 18:25:02 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 26 18:25:02 2021 |
tree | a2e0140b1320938872c56f51422fe776827577ea | |
parent | 6b59301f7f56ce1df5a8ac6d9c21aa5fec9a7bfe [diff] |
Fix two issues in TSFTextStore::QueryInsert We used to use |base::ClampToRange| to make sure that the given |acp| start and end is within |composition_start| and |buffer_size|. However, crrev.com/905034 replaced |base::ClampToRange| with |base::Clamp| which ensures that the given range must be nomalized(start < end). However, |composition_start| might be greater than |buffer_size| during IME replacements which result in application crash. Second issue is that we are not reporting correct |acp_result_end|. We should consider given |text_size|. Bug: 1243400 Change-Id: Ib0c55c7aa947b662a5526f231499ff78381f4ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3119827 Reviewed-by: Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/main@{#915655}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.