commit | aa78f3b3b262395c7901d6a6f1377ccf830d17ce | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Fri Jun 06 18:07:52 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 06 18:07:52 2025 |
tree | 8da69f401ecfcd1796d58c243b5c165243fd95ed | |
parent | 54fe47e42701e8cba73c9b493ba1695c9e3f7083 [diff] |
Fix the use of enable_extensions{_core} in c/b/ui/extensions/BUILD.gn [1] started the componentization of c/b/ui/extensions, but some of the guards in the original c/b/ui/BUILD.gn file were not respected, which causes problems to move forward with the componentization. Basically: - c/b/ui/extensions/BUILD.gn needs to explicit separate what headers (and later .cc) files are actually guarded by `enable_extensions` and `enable_extensions_core`. This is needed because Android/Desktop builds enable the later only. - The assert in the top of the c/b/ui/extensions/BUILD.gn file ins't valid, since Android/Desktop builds actually have `enable_extensions_core` enabled, but not `enable_extensions`. This should bring no behavior change, but actually prepare to the rest of the componentization of this directory. [1] https://crrev.com/c/6598020 R=dljames@chromium.org Bug: 420905611 Change-Id: Ie7dfec4676265d13ab6df58a3e203959ef475c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6620772 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Darryl James <dljames@chromium.org> Cr-Commit-Position: refs/heads/main@{#1470666}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.