commit | aa7d1eed6b0374de813d66c424e90906f0258fc1 | [log] [tgz] |
---|---|---|
author | Xianzhu Wang <wangxianzhu@chromium.org> | Thu Aug 18 22:32:32 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 18 22:32:32 2022 |
tree | 60be8da11f927801ed2498e3ece00255789606e6 | |
parent | be24990c223234675f9ed7193b5946d65393166e [diff] |
[ScrollUpdateOptimizations] Fix fixed-position overlap testing 1. Fall back to the generic cross-scroll overlap testing if there is any additional clip between the fixed-position state and the scroller overflow clip because the expanded fixed-position rect would be incorrectly clipped. 2. Also use CompositingReason::kFixedPosition for special fixed- position compositing reasons in a non-scrollable viewport, to use the fixed-position code path in overlap testing if possible to avoid extra overlaps. Found the issues because the following tests failed with ScrollUpdateOptimizations enabled by default: external/wpt/css/css-multicol/fixedpos-static-pos-with-viewport-cb-001.html external/wpt/css/css-multicol/fixedpos-static-pos-with-viewport-cb-002.html external/wpt/css/css-multicol/fixedpos-static-pos-with-viewport-cb-003.html external/wpt/css/css-position/position-fixed-scroll-overlap.html I probably only checked blink_web_tests for failures when I tried the original ScrollUpdateOptimizations CL with the feature enabled. Bug: 1346789 Change-Id: Ia6fbcd72aebb355b1ba42f5c332a8e61a679ee66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838628 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1036822}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.