| commit | aabf10bf21cfe97f2894510098865bbbeaa4519a | [log] [tgz] |
|---|---|---|
| author | Alan Screen <awscreen@chromium.org> | Fri Jan 29 23:54:45 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 29 23:54:45 2021 |
| tree | b5c2c01209fcb131f9dfd2369026424c85b84353 | |
| parent | 28deb9704ab93d1fcad44a533a52e8233916da99 [diff] |
resource_coordinator: Migrate callbacks from base::Callback WindowedNotificationObserver constructor uses ConditionTestCallback which is explicitly a repeating callback [1], since the callback can be made multiple times - whenever the condition of interest is met. The closure used in WaitForLoadingStateHelper is only ever invoked once, when a RunLoop quits, so it can be a OnceClosure. This is part of the base::Callback migration. Context: https://source.chromium.org/chromium/chromium/src/+/master:docs/callback.md;drc=ddc84d470a7d89255b7af81584a09d0cfb3e3cf2;l=40-44 [1] https://source.chromium.org/chromium/chromium/src/+/master:content/public/test/test_utils.h;drc=699e1bd813aa71e101fc20a6ded0d23a277181e4;l=241-243 Fixed: 1170959 Change-Id: Ida90b5d49e2351f40c0cacd61d596da04162f0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657835 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#848786}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.