Revert "[//cc] Add MappableSI path to OneCopyRasterBufferProvider" This reverts commit 031f7c9ee19d8524abd7a1351b2e10de44ac78bf. Reason for revert: Might cause a test consistency failure on https://ci.chromium.org/ui/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel Apologize for reverting. Please feel free to reland if it is not related, thanks. Original change's description: > [//cc] Add MappableSI path to OneCopyRasterBufferProvider > > This CL adds a new path to OneCopyRasterBufferProvider that uses > MappableSharedImage rather than GpuMemoryBuffer. The new path is > protected by a killswitch. The gist of the change is that rather than > creating a GpuMemoryBuffer, mapping that in, and then later creating a > SharedImage from it, the new path directly creates a > MappableSharedImage (via the new CreateSI() entrypoint), maps that in, > *and* additionally uses it in the same ways that the SI created from > the GMB is being used. > > One subtlety is that the GMB is created with the size of the > StagingBuffer, while the SharedImage for the StagingBuffer in its > current creation point in CopyOnWorkerThread() is created with the > `resource_size` param passed to PlaybackAndCopyOnWorkerThread(). Thus, > we would want the MappableSI for the StagingBuffer to be created with > "both" sizes. Fortunately (and as one would expect), the StagingBuffer > is initialized with the `resource_size` param, so the two sizes are > guaranteed to be the same [1]. > > [1] https://source.chromium.org/chromium/chromium/src/+/main:cc/raster/one_copy_raster_buffer_provider.cc;l=295-297?q=CopyOnWorker&ss=chromium > > Bug: 1431314 > Change-Id: Id30b483c98247bd72a3f68d91d0a88474e006477 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4851302 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: vikas soni <vikassoni@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1200093} Bug: 1431314, b/301608467 Change-Id: I0dcdcf341c7e537f839ac60d424808c66fbf82b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4889244 Reviewed-by: Min Chen <minch@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Min Chen <minch@chromium.org> Owners-Override: Min Chen <minch@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1200605}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.