commit | ab38f10f2d89786063f74493358f7eeb9966c495 | [log] [tgz] |
---|---|---|
author | André Bianchessi <abianchessi@chromium.org> | Mon Apr 14 19:21:39 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 14 19:21:39 2025 |
tree | 77a764f5ba0068406bd16d7397c94fe16ceb0119 | |
parent | c0338f8b697f7e752117b57cb607fbe5b761162d [diff] |
Migrate PWA Page Action (IPH pending) This CL migrates the [1] PWA Install page action to the new Page Actions framework. There are two changes in behavior with the new implementation: 1 - The new implementation animates the label (the suggestion chip) in and out, whereas the previous one used [2] `ResetSlideAnimation(false);` to animate out. 2 - The legacy implementation only showed `Install` [3] in the suggestion chip, but the new one shows `Install <App Name>` [4]. The test was slightly modified to accommodate for those two changes. Also, the `TextContrast` test was deleted because the chip contrast/color will be responsibility of the new framework and feature code should not test it. The IPH code was not yet migrated and will be in a follow-up CL. Bug: 376283433 Change-Id: Id0d41df021b368bf90b34998bcf8ee68ddc90eeb [1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/page_action/pwa_install_view.cc [2] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/page_action/pwa_install_view.cc;l=141;drc=a48632411d7e7263e8fd4d273d24a80f668b73ec [3] https://issues.chromium.org/action/issues/40603345/attachments/53098238?download=true [4] https://screenshot.googleplex.com/4BcgGFwvahT9tKC Change-Id: Id0d41df021b368bf90b34998bcf8ee68ddc90eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6438329 Reviewed-by: David Pennington <dpenning@chromium.org> Commit-Queue: André Bianchessi <abianchessi@chromium.org> Reviewed-by: Eshwar Stalin <estalin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1446699}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.