commit | aba318bb00c92df222ff922b4476c60e2e51d982 | [log] [tgz] |
---|---|---|
author | Sunny Sachanandani <sunnyps@chromium.org> | Wed Sep 06 20:22:22 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 06 20:22:22 2023 |
tree | 63db54ff9cb9860b9a137f9e77dccaf1cda21a55 | |
parent | 413add64bd61348332bb3f9b4a61906f1d405eda [diff] |
graphite: Skip Graphite feature check early for unsupported devices ANGLE Metal won't be enabled by default in code on M118 yet which means it's still on a 50% Canary/Dev/Beta trial. Since Graphite requires ANGLE Metal and fallsback to GL without it, this would lead to a difference in populations between the experiment arms. Unfortunately checking for ANGLE Metal is not as straightforward as checking the feature flag, since ANGLE requires the "Mac2" GPU family to enable its Metal backend, and the SkiaGraphite feature flag is checked in the browser process when constructing GpuPreferences so we can't initialize ANGLE and check which backend it used. Therefore, this CL tries to filter out unsupported devices by using the model identifier using this list that the ANGLE team compiled: https://docs.google.com/spreadsheets/d/1GG74f_MTA4oAJcdM7_GxbxjUtXTpwNgptMVLNTRBVfw/edit#gid=0 Bug: 1423574 Change-Id: I0bd740386cea28945b98d378b1a4b3df8b78963f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4842780 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/main@{#1193227}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.