commit abcd4e1492adaa27a80aa20134fec0fb0ee69955
author Vinny Persky <vinnypersky@google.com> Mon Oct 30 22:43:02 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 30 22:43:02 2023
tree 6f29ab4ab311005cd1f6a09b64c68e164944d957
parent 7c2f8f0adaf80ff565291e30aa57b1c8f225aa4e

Make credit card filling functions not pure virtual in AutofillClient

This CL makes credit card filling related functions in AutofillClient
non-virtual. This is a cleaner implementation and we should go in this
direction for payments features as many (if not all) of them aren't
implemented on all platforms, resulting in us having a lot of
overridden functions that aren't implemented or BUILDFLAGs to protect
against possible not-implemented compile errors.

This CL is a pre-requisite for go/autofillclient-payments-refactor-design.

Bug: 1494289
Change-Id: I7fd48426ff563a23b5053df204c7c0305302dbae
Low-Coverage-Reason: This CL only refactors existing classes that don't have unit tests. The refactored classes don't have much business logic, they are just the dependency injection and UI interface for some of our flows.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4974135
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Reviewed-by: Olivia Saul <jsaul@google.com>
Commit-Queue: Vinny Persky <vinnypersky@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217242}