commit | abe4f157e53e4945d13645241dc640eea7522d4c | [log] [tgz] |
---|---|---|
author | Colin Kincaid <ckincaid@chromium.org> | Fri Mar 10 17:45:34 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 10 17:45:34 2023 |
tree | 1a132e8f1b6b522d2de94b7cc62ee26b389d6e76 | |
parent | 2d541116309278721a30eef5e2de3b8fa1dfa72c [diff] |
Revert "[Files F2] Use want/got style in unit test to do assertion" This reverts commit 0dd6b0536d2c627243e7c25e3350d8efb00b12cb. Reason for revert: https://crrev.com/c/4150614, which this CL was based on, broke several Crostini tast tests according to the bisector. Bug: b/272557385 Original change's description: > [Files F2] Use want/got style in unit test to do assertion > > * Remove some mock methods because now we use the real data to convert > entry to FileData, or to convert volumeInfo/volumeMetadata to Volume. > * Add missing ui entries to the store: > * MyFiles entry list > * Google Drive entry list > * Grouped removable entry list > > Bug: b:271485133 > Test: browser_tests --gtest_filter="*FileManagerJsTest*Reducer*" > Change-Id: Iffaa2591f09d5033eb81e9272665097df55fa00d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4318782 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Wenbo Jie <wenbojie@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1115400} Bug: b:271485133 Change-Id: Ib6907f70845ea54aa847263f822b783035caf42a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4327120 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Colin Kincaid <ckincaid@chromium.org> Owners-Override: Colin Kincaid <ckincaid@chromium.org> Cr-Commit-Position: refs/heads/main@{#1115778}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.