commit abe9494f430dbe078a830ba0c4fb99a6ee235263
author Peter Boström <pbos@chromium.org> Mon Mar 10 21:51:10 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 10 21:51:10 2025
tree ba63da8cd6cfd84a849bfa4a25319f837c3d7472
parent 5478540d68bec166cb7830938dedf6b36a168ec2

Detangle CHECK() failures from std::ostream

This adjusts code paths to not rely on streaming CHECK() failures to a
std::ostream, which required both that an underlying ostream object
exists and that the logged type was not the first argument streamed to
a CHECK() failure.

This intends to unlock further optimizations (can skip logging steps) as
no std::ostream object needs to be generated. This may be used for
skipping constant strings in official builds where they don't contribute
to debuggability (i.e. streaming a string constant may for instance just
return *this).

Bug: 378574882
Change-Id: I594c1fec8ed8757ac54ecef5239de24db82a80cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332885
Owners-Override: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1430504}