commit abf1adcc41f6d57178ebf6da1769e94445907cb9
author Tsuyoshi Horo <horo@chromium.org> Thu May 16 05:53:41 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 16 05:53:41 2024
tree 0343a6e45ecf3360d6fad70b70ba4f0ce8a6fe0b
parent 2c0bcc9cb04401eb824b71a4a728620d7fb74f05

Stop using ThreadSafeRefCounted for BackgroundResponseProcessor

BackgroundResponseProcessor class is currently ThreadSafeRefCounted. And
BackgroundResourceScriptStreamer's BackgroundProcessor lives in the
main thread, the background thread of loading and the worker thread of
JS parsing. This complicates lifetime management of the class. Also
we can't use WeakPtrFactory for the class (See crrev.com/c/5514715).

To solve this problem, this CL introduce a new factory class named
BackgroundResponseProcessorFactory. After this cl, the factory class
is created in the main thread, and passed to the background thread of
loading. And its Build() method will be called in the background thread
to create a BackgroundResponseProcessor. The BackgroundResponseProcessor
will live only in the background thread.

Currently BackgroundResourceScriptStreamer::FinalizeOnMainThread() is
called to take the result from the BackgroundResponseProcessor. But
after this CL, the result is passed from the background thread to the
main thread using CrossThreadWeakHandle of
BackgroundResourceScriptStreamer.

This CL also removes BackgroundResponseProcessor::Cancel() method,
because the owner of BackgroundResponseProcessor can cancel just by
deleting the BackgroundResponseProcessor.

The new relationship diagram:
https://docs.google.com/drawings/d/1W9F8SPkA9fxQYuJRHCKH5C9kbrQDP30qI-qOLIGIaok/edit

Bug: 40244488
Change-Id: I947e3e193ce6431656f103f0ac7dddb57c4b1e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528481
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301764}