| commit | 0af07f838ec90944f4ab9d43d098aecbef6d49b2 | [log] [tgz] |
|---|---|---|
| author | Aaron Leventhal <aleventhal@google.com> | Thu Aug 15 12:19:49 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 15 12:19:49 2024 |
| tree | dead4bcfdc163f0e536985a8d6af82d92e655633 | |
| parent | 89944c4b718f8ffb8135b264651b5b7daa477529 [diff] |
Reland #2 "[A11y] When repairing prohibited name, avoid redundant description" This is a reland of commit 6946fa28397a7f9990ff4ba3b95ca227f033dc22 Reason for revert: All/DumpAccessibilityTreeTest.AccessibilityProhibitedName/blink is consistently failing on Mac13 Tests as well as any bot that has DCHECKs turned off: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac13%20Tests/18046/overview ================================================================== The issue stemmed from a bad rebase that failed to remove an outer #if DCHECK_IS_ON(), and errantly ablated the implementation code. ================================================================== The error reproduces on linux-bfcache-rel, which has been added to the try bots for this CL. Original change's description: > [A11y] When repairing prohibited name, avoid redundant description > > Do not expose the prohibited name as a description if it would be > redundant with the inner contents of the object. > > Also, implement ATK/IA2 name-from object attribute so that ATs can > make their own determination as to the value of the repaired name. > For more info about name-from, see: > https://docs.google.com/document/d/1-zjGmiOtjrHeBjXVGkhCcK2ya4Xq_k3yerHqSi_3qsY/edit#heading=h.benybc8eru3u > > Bug: 350528330 > Change-Id: Ibe2d4ccb777c24f0b5a471b8b45848051add0004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900708 > Reviewed-by: Tim <tjudkins@chromium.org> > Reviewed-by: Brendon Tiszka <tiszka@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#1338011} Bug: 350528330 Change-Id: Ie5f22cd41b66f6c7ec06783b4e3a5fa1e4a9a935 Cq-Include-Trybots: luci.chromium.try:linux-bfcache-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789346 Reviewed-by: Tim <tjudkins@chromium.org> Reviewed-by: Brendon Tiszka <tiszka@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1342221}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.