Revert "ipcz: Support dynamic runtime features" This reverts commit 662e73f5705cdd9b089c8785e42096abf3ea9587. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5200924853141504 Sample build with failed test: https://ci.chromium.org/b/8751158003263844609 Affected test(s): [ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/adoption-agency-crash-01.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fadoption-agency-crash-01.html?q=VHash%3Ad656188f56ce4659) [ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/badurl-base-preloader-crash.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fbadurl-base-preloader-crash.html?q=VHash%3Ad656188f56ce4659) [ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/body-should-exist-after-open-close.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fbody-should-exist-after-open-close.html?q=VHash%3Ad656188f56ce4659) [ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/broken-comments-vs-parsing-mode.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fbroken-comments-vs-parsing-mode.html?q=VHash%3Ad656188f56ce4659) [ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/changing-attrbutes-crash.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fchanging-attrbutes-crash.html?q=VHash%3Ad656188f56ce4659) and 85 more ... If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5200924853141504&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5420430&type=BUG Original change's description: > ipcz: Support dynamic runtime features > > Runtime features have generic integer identifiers to be defined in > ipcz.h. Applications can enable or disable features through CreateNode() > options, effectively allowing Chrome feature flags to influence internal > ipcz features. > > Features enabled on a node are automatically shared with any connected > nodes, allowing nodes to agree up-front about which features > (e.g. protocol additions) to use in each others' presence to avoid any > risk of wire incompatibility at runtime. > > This is a precursor to supporting alternative shared memory management > and usage, among other future improvements. An initial > IPCZ_FEATURE_MEM_V2 feature is added as a no-op for now. > > Bug: 332719403 > Change-Id: I01bfc2c7aab73912c3495d25c8373ae33610ad38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420430 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1284291} > Bug: 332719403 Change-Id: I532dae7ad4342b89a3b44ae8c0c55a0de5b85d5d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5437569 Owners-Override: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/main@{#1284390}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.