| commit | ac52e29953ac5e4d4b3c6f052e8c48906e1b922a | [log] [tgz] |
|---|---|---|
| author | Tom Sepez <tsepez@chromium.org> | Thu Dec 07 02:00:03 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 07 02:00:03 2023 |
| tree | 3c43b1722017f58522bed6d646c5dd056635e498 | |
| parent | d4bc08c6804dbe1d010dfbdb5057b8800f1e63c6 [diff] |
Remove special case for single-blocks in StorageBlock. Without fully reworking memory ownership, simplify the code, as the special case for n == 1 blocks doesn't buy us very much. Then use new T[] rather than new char[] since class T must be trivial. Having converted to new T[], we can use .ClearAndDeleteArray() to avoid the momentary quarantine and poisoning of the buffer caused by deleting through .ExtractAsDangling(). Change-Id: Id1180f1076d4c883f32b1e2f8aafbcb34a078f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5035308 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1234304}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.