Google Git
Sign in
chromium / chromium / src / ac622f14bee19c3531d8e3db2dfb504267dd7f2a
commitac622f14bee19c3531d8e3db2dfb504267dd7f2a[log] [tgz]
authorKevin Ellis <kevers@google.com>Wed Mar 06 19:38:11 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 06 19:38:11 2024
treefee834fd57f289567cc26a353d7840719ab9c6ec
parent10667ceb5ac36949f8b13d8374118dc979a9d29b [diff]
Fix timeout in svg-mouse-listener a11y test

The recommended approach to make a crash test asynchronous is to use
reftest-wait. Unfortunately, test-driver does not work with ref-tests.
The fix is to pull the test out of crashtests and author as a promise
test.  This is the only a11y crash test that uses test-driver, and
thus, the only one that is affected.

The test needs to be asynchronous to avoid a memory leak. The reason is
due to the fact that we have armed an event listener that is never
triggered unless we wait. A crash-test only waits until onload is complete.

Bug: 328403023
Change-Id: If33410bd498995b8216e805c8edc27c093e3db1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5348198
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1269156}
2 files changed
tree: fee834fd57f289567cc26a353d7840719ab9c6ec
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.