commit | ac6438b60a45ac4bdf519fa4c8233fd411631197 | [log] [tgz] |
---|---|---|
author | Daniel Cheng <dcheng@chromium.org> | Mon Sep 26 16:32:33 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 26 16:32:33 2022 |
tree | a073581389d6cbe8fb028286f2ed048c0c9f8a97 | |
parent | 344c0a5926f9f847376ec64dac30ce1dff3a113b [diff] |
Use helper macros to define base::Features in //components/web_cache This allows: - features to be defined with a consistent set of qualifiers, and for that set of qualifiers to be updated over time as appropriate. - better PRESUBMIT checks to ensure that base::Features are not defined in headers. - simplifies things for scripts trying to extract feature definitions out of C++ code. The primary CL was generated using a script that automatically rewrites base::Feature declarations and definitions to the macro form. Changes to any files with known incompatibilities with the macros (base::Features without static storage duration and base::Features declared as static class members) were then fully reverted; those changes will be manually handled in followups. This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 1364289 Change-Id: I0a557e0720c3efedc0b473db24d44fff0f906893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914481 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1051263}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.