Google Git
Sign in
chromium / chromium / src / ac6a56d8b7d742b83fa00aaa171bdc0f6ebd2e94
commitac6a56d8b7d742b83fa00aaa171bdc0f6ebd2e94[log] [tgz]
authorDelan Azabani <dazabani@igalia.com>Fri Mar 17 16:21:46 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Mar 17 16:21:46 2023
tree2249251f8bd695dcf5b6ccd9c83e35dfb21742f3
parent7083b41724acd98265fef0eb60303c6335986cd3 [diff]
CSS highlight painting: fix heap-use-after-free and NOTREACHED bugs

The ctor for NGHighlightPainter stores the ComputedStyle for each
highlight pseudo in a LayerPaintState field for use by later method
calls, but it unwraps the scoped_refptr<ComputedStyle> into a raw
pointer first, allowing the values to be freed before use. This patch
makes LayerPaintState hold the refcounted pointer itself.

ForcedForegroundColor and ForcedBackgroundColor lacked cases for the
::spelling-error and ::grammar-error pseudos, yielding a NOTREACHED()
crash when painting those highlights in forced colors mode. This patch
adds cases for those pseudos, fixing the crash.

Fixed: 1422533, 1423540
Change-Id: Ied7eaafea601a044b2c8e35889e0d36aa43ab791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350127
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118687}
5 files changed
tree: 2249251f8bd695dcf5b6ccd9c83e35dfb21742f3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.