commit | acdb7f9113eb47f1efd2bc2235884c81a46df72a | [log] [tgz] |
---|---|---|
author | Elliot Tuck <etuck@chromium.org> | Fri Dec 01 16:08:12 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 01 16:08:12 2023 |
tree | e93abeab07248315a0fe14c7f32691f2e4956b0c | |
parent | af4193ceb2504e9161470613ee3ba71b84cfa009 [diff] |
Reland "vc-dlc-ui: Use `FeatureTile` for VC effect tiles" This is a reland of commit 8e03cfd7983fca8d9d098236638859b48e1464d8 The only change that is needed from the original CL is replacing `views::Button::PressedCallback()` with `base::RepeatingClosure()` in a/s/v/e/video_conference_tray_effects_manager_unittest.cc (see the diff between Patchset 1 and Patchset 2). Original change's description: > vc-dlc-ui: Use `FeatureTile` for VC effect tiles > > Replace `ToggleEffectsButton` with `FeatureTile` when VcDlcUi is > enabled. More work will need to be done within `FeatureTile` to get the > UI to match that of the existing `ToggleEffectsButton`; this CL just > gets the ball rolling by allowing `FeatureTile`s to show up in the VC > controls bubble at all. > > > Bug: b:312771691 > Change-Id: I50ea3d9d965d807db8d0a98404daa76b29478bdc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055673 > Reviewed-by: Andre Le <leandre@chromium.org> > Commit-Queue: Elliot Tuck <etuck@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1231908} Bug: b:312771691 Change-Id: Ie7da28d101bc07df67f1cc9e775228093c05d7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5075162 Commit-Queue: Elliot Tuck <etuck@chromium.org> Reviewed-by: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/main@{#1231955}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.