Move ExtensionService::CreateUpdateInstaller() to ExtensionUpdater ExtensionService has many dependencies that aren't yet supported on desktop Android, so we're moving code out of it into places where we can port. ExtensionService::CreateUpdateInstaller() has a single caller, in ExtensionUpdater, so move it there. The ExtensionUpdater tests extensively use a delegate interface with the CreateUpdateInstaller() method for sensing. Rename that delegate interface to CrxInstallerProviderForTest and make it only used in tests. Production code can directly call CreateUpdateInstaller(). Provide a test-only constructor that maps to existing unit test code for ExtensionUpdater, to minimize churn in the tests. Some tests that use an "empty" extension service are updated to have an ExtensionUpdater instance so they can call the method. This will be simplified in a future CL when ExtensionUpdater becomes a profile keyed service. No functional changes, just refactor. Bug: 404943906 Change-Id: Ic263f9b7b2869e3bb8ac9a16bedc2c6965037227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387852 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1437890}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.