Google Git
Sign in
chromium / chromium / src / ace649bbc0f17f7158ad77fbfd68bfd19eee032c
commitace649bbc0f17f7158ad77fbfd68bfd19eee032c[log] [tgz]
authorRyan Sultanem <rsult@google.com>Fri Oct 11 12:08:05 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 11 12:08:05 2024
tree8e99c2e83147081fd62b92b5204c83181d9f5ac5
parent1e1513195ebd570e0b42ef8dc4dcb9f90d022539 [diff]
[BatchUpload] Change the data/model key mapping

In preparation to using SyncService DataTypeLocalDataBatchUploader
interface, we simplify the mapping between the data and their models.
Now using the real data key, instead of expecting the interface to keep
record of the mapping of the displayed items.

This forces the BatchUploadDialogHandler itself to keep track of its
own id mapping per data type, given that Mojo can only support one id
type, in order to retrieve back the right data id.

This way the Id mapping complexity is decoupled from the data types.

Currently the allowed Ids are only strings since it is the expected id
type to be used first. But in theory, if any other id type is needed,
the `BatchUploadDataItemModel::DataId` should support multiple types
through `std::variant`, and it would be up to the data type to
ensure the right data id type.

Bug: b:372701325
Change-Id: I11b1f204c021f3d6c6c23a329b1fd424cd3cca78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5922707
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Cr-Commit-Position: refs/heads/main@{#1367448}
14 files changed
tree: 8e99c2e83147081fd62b92b5204c83181d9f5ac5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.