Google Git
Sign in
chromium / chromium / src / ad312c2086d04b80dd453959740bb7f49ee287c7
commitad312c2086d04b80dd453959740bb7f49ee287c7[log] [tgz]
authorHaiyang Pan <hypan@google.com>Tue Sep 24 15:56:29 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Sep 24 15:56:29 2024
treee8b9865497c66d8f0adc9d7819df9d8f53d44d30
parent2ddbb78c0eb055d8fb609aff6f7a81d858e49107 [diff]
Revert "Use Chrome's fading shadow implementation for IncognitoNTP"

This reverts commit 4db7d8944ecd4c49a744497b20a94d74687f3b6b.

Reason for revert: Caused the emulator crash issue, as described
and reproduced in https://crbug.com/368675202#comment5

Original change's description:
> Use Chrome's fading shadow implementation for IncognitoNTP
>
> Replace the view's fading shadow into Chrome's FadingShadowView and
> FadingEdgeScrollView. This is a workaround that #requiresFadingEdge
> doesn't work with #clipToPadding for ScrollView.
>
> Before (not edge to edge):
> https://screenshot.googleplex.com/9XESPLDvzviZ5cJ
> After:
> https://screenshot.googleplex.com/83Kd2unzVMBjEvr
>
> Bug: 365607068
> Change-Id: Ia156e10712de32f7141f379e1926fbcb3251caf0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5846890
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: Lijin Shen <lazzzis@google.com>
> Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1357331}

Bug: 365607068, 368675202
Change-Id: I63c22f3faa162a55718d4a9c6bee481989d12a6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5884627
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/main@{#1359390}
4 files changed
tree: e8b9865497c66d8f0adc9d7819df9d8f53d44d30
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.