commit ad419113040ccf0ab952ca772c1641bfc6166079
author Gauthier Ambard <gambard@chromium.org> Fri Apr 18 10:16:49 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Apr 18 10:16:49 2025
tree b3a2d2a5c52499923e28afb412dc512b0cb57edf
parent 5cdb0514b91638090c902183f4a780284b5f2ea9

[iOS] Fix FacePile layout in TabGroupView

The position of the facepile in the button wasn't clear.
This CL adds constraints to ensure it is properly positioned.

https://screenshot.googleplex.com/5MXDfFYck2vMfaB
https://screenshot.googleplex.com/5W35y5sFeZ6mBnV

Bug: 407545906
Change-Id: I8a82ceb5551de9c5b5a0e80794877b53faed51fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6469637
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1448810}

ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_group_view_controller.mm

diff --git a/ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_group_view_controller.mm b/ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_group_view_controller.mm
index 3a22d6b..c26cc33d 100644
--- a/ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_group_view_controller.mm
+++ b/ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_group_view_controller.mm
@@ -422,8 +422,6 @@
   if (IsContainedTabGroupEnabled()) {
     [_topToolbarButtonsStackView insertArrangedSubview:_facePileView atIndex:0];
   } else {
-    _facePileView.translatesAutoresizingMaskIntoConstraints = NO;
-    [self.view addSubview:_facePileView];
     [self configureNavigationBarItems];
   }
 }
@@ -580,6 +578,7 @@
   UIBarButtonItem* facePileBarButton;
   if (_facePileView) {
     _facePileView.userInteractionEnabled = NO;
+    _facePileView.translatesAutoresizingMaskIntoConstraints = NO;
 
     UIButton* facePileButton =
         [[UIButton alloc] initWithFrame:_facePileView.bounds];
@@ -598,6 +597,12 @@
     [NSLayoutConstraint activateConstraints:@[
       [facePileButton.widthAnchor constraintEqualToConstant:kFacePileWidth],
       [facePileButton.heightAnchor constraintEqualToConstant:kFacePileHeight],
+      [facePileButton.leadingAnchor
+          constraintLessThanOrEqualToAnchor:_facePileView.leadingAnchor],
+      [facePileButton.centerYAnchor
+          constraintEqualToAnchor:_facePileView.centerYAnchor],
+      [facePileButton.trailingAnchor
+          constraintEqualToAnchor:_facePileView.trailingAnchor],
     ]];
 
     facePileBarButton =