Use ChildServiceConnectionController.isUnbound() to prevent binding status change after unbind()

This change introduces a new feature flag, UseIsUnboundCheck, to switch
the connection status check in ChildProcessConnection.java from
isConnected() to the safer ChildServiceConnectionController.isUnbound().

The isConnected() method, which checks for a non-null service object,
can be false temporarily during connection setup before the connection
is fully established. This creates a race condition where
binding-related calls (like addStrongBinding) can proceed, but later
calls (like removeStrongBinding) might fail with an assertion error if
the connection is not actually bound, as the binding count would be
mismatched.

The mConnectionController.isUnbound() method provides a more reliable
state, as it remains false until the connection is explicitly unbound
and does not become true again. Using this check prevents assertion
failures by ensuring that binding modifications only occur on a
genuinely bound connection.

Bug: 447057423

Change-Id: Ia5f420eae8a3ad2f02243b5df1c400ee0ed9a909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6978154
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Shin Kawamura <kawasin@google.com>
Cr-Commit-Position: refs/heads/main@{#1520988}
7 files changed
tree: eacd3fed3b939d435f44de68e491a95ec2ddb63f
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.