Google Git
Sign in
chromium / chromium / src / ad5158e392bf02a46d9688619bd70e3d4953cd28
commitad5158e392bf02a46d9688619bd70e3d4953cd28[log] [tgz]
authorAdithya Srinivasan <adithyas@chromium.org>Fri Jan 26 15:41:55 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 26 15:41:55 2024
treefbd89b75ba3f3b21db6ce803d0053387cc6cbc8d
parentfef55720b59a7759c452fd6634bea8d1011aa7c5 [diff]
Prefetch: Prevent PrefetchContainer::OnCookiesChanged from being called twice

It was previously possible for OnCookiesChanged to be called twice
in a scenario where a NavigationRequest to a URL is cancelled, and
then replaced by another NavigationRequest to the same URL. This CL
fixes this by preventing GetPrefetch from selecting a prefetch that
has already been marked as unusable because the cookies have changed.

This CL also removes a codepath in OnGotPrefetchToServe that was never
being used in practice (there are comments in the code explaining
why). It also removes a unit test that was exercising this code path.

Bug: 1491889
Change-Id: Ic10cdcde1e12ec24710d47dea5c192325df4b1f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5232813
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1252649}
5 files changed
tree: fbd89b75ba3f3b21db6ce803d0053387cc6cbc8d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.