commit | ad7345012bdf6a10785e89c75f36bf925fba9174 | [log] [tgz] |
---|---|---|
author | Lichen Liu <lichenliu@microsoft.com> | Wed Jun 12 09:46:12 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 12 09:46:12 2024 |
tree | b6324e3236512c3c0fc803638c3128b9710eb667 | |
parent | 266c8c9a8a53bcad060b1191b065b5f1ed697d22 [diff] |
Change GetTooltipTextAt to async in remote cocoa There're some crashes occur occasionally in the mojo engine when calling GetTooltipTextAt, which is a synchronous mojo message lived on an associated mojo handle. It should be due to file descriptor exhaustion since the client process' default limit is 256 which is a little small, and remote cocoa could send a lot of mouse or keyboard events in a short time. But for this mojo message, we think it's better to change it to asynchronous since we do not see strong need to use synchronous message here, and as we all know, synchronous mojo message is actually discouraged. With this, we can workaround the crash issue, and if it works well, then we can change more synchronous message in native_widget_ns_window_hos.mojom to asynchronous gradually. Bug: 343754415 Change-Id: I1dae22bc2450c32f49b8a97edf4426760c6f87c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5587824 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Leon Han <shulianghan@microsoft.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lichen Liu <lichenliu@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1313891}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.