Fix bugs and improve perf in Touch Bar text suggestions.

- The old implementation recreated the Touch Bar on each keystroke (including
  when hidden, I believe), which burns a significant amount of power while
  typing. This new implementation updates the existing candidate list, if it
  exists and isn't collapsed.

- Removes a bunch of support code for a behavior that was disabled in r590669.
  It moves the remaining code into RWHV itself instead of a dedicated
  controller class, which I have mixed feelings about, but ultimately picked
  because after the support code was removed, most of what was left was
  plumbing between RWHV and TextSuggestionsTouchBarController.

- [Bigish change] Moves text suggestions out of the window and into the RWHV,
  so that hiding and showing as focus and web contents change is left to AppKit
  and the responder chain.

- Fixes small lifecyle-ish bugs around when use this kind of Touch Bar — now
  it's tied to the RWHV's input type instead of using a special

Bug: 717553, 881545
Change-Id: I8e1eff6da7918f92cfdb47465196d5841a88a7e4
Commit-Queue: Sidney San Martín <>
Reviewed-by: Avi Drissman <>
Cr-Commit-Position: refs/heads/master@{#597371}
28 files changed